Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Quality: Removed $(TargetFrameworkVersion)-windows$(TargetWindowsVersion) #16816

Merged
merged 2 commits into from
Feb 16, 2025
Merged

Code Quality: Removed $(TargetFrameworkVersion)-windows$(TargetWindowsVersion) #16816

merged 2 commits into from
Feb 16, 2025

Conversation

Lamparter
Copy link
Contributor

Resolved / Related Issues

Steps used to test these changes

  1. Built Files

Replaces the explicit $(TargetFrameworkVersion)-windows$(TargetWindowsVersion) with a global $(WindowsTargetFramework) switch.

hez2010
hez2010 approved these changes Feb 15, 2025
View reviewed changes
Copy link
Member

@hez2010 hez2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Directory.Build.props Outdated Show resolved Hide resolved
@Lamparter @hez2010
Remove empty line
873cf75 
Co-authored-by: Steve <[email protected]>
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Feb 16, 2025
@yaira2 yaira2 merged commit 4d7f200 into files-community:main Feb 16, 2025
6 checks passed
@Lamparter Lamparter deleted the windowstfm branch February 16, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hez2010 hez2010 hez2010 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lamparter @hez2010 @yaira2