-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Update the Drives Widget & Tags Widget when refreshing the Home Page #16732
Feature: Update the Drives Widget & Tags Widget when refreshing the Home Page #16732
Conversation
@yaira2 I'm not sure we should use the filewatcher to update drives. If a user is copying many items this would slow down the process |
That could be a concern, we might be better off reloading the details only when the user refreshes the page. |
Couldn't it refresh when the home page is opened, that way it auto refreshes without the performance issue |
This seems a good workaround, I'll look into it |
Is this automatic, or does it require refreshing the page? |
It was automatic but I reverted it in the last commit. I can re-revert it if it's needed |
So just to confirm, aside from when the settings change, the only live updating is when manually refreshing & when navigating to the home page? |
Currently the behaviour is as follows:
Introduced in this PR:
I can add back the code to update the |
src/Files.App/ViewModels/UserControls/Widgets/RecentFilesWidgetViewModel.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build
. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.Steps
Refresh
button actually refresh the home pageTags
when changes are detectedTags
when files are taggedSteps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.