Skip to content

Commit

Permalink
Use ide friendly name
Browse files Browse the repository at this point in the history
  • Loading branch information
yaira2 committed Feb 11, 2025
1 parent 7015edd commit 1420b70
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion src/Files.App/Actions/Open/OpenInIDEAction.cs
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public async Task ExecuteAsync(object? parameter = null)
);

if (!res)
await DynamicDialogFactory.ShowFor_IDEErrorDialog(_devToolsSettingsService.IDEPath);
await DynamicDialogFactory.ShowFor_IDEErrorDialog(_devToolsSettingsService.IDEFriendlyName);
}

private void Context_PropertyChanged(object? sender, PropertyChangedEventArgs e)
Expand Down
2 changes: 1 addition & 1 deletion src/Files.App/Actions/Open/OpenRepoInIDEAction.cs
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public async Task ExecuteAsync(object? parameter = null)
);

if (!res)
await DynamicDialogFactory.ShowFor_IDEErrorDialog(_devToolsSettingsService.IDEPath);
await DynamicDialogFactory.ShowFor_IDEErrorDialog(_devToolsSettingsService.IDEFriendlyName);
}

private void Context_PropertyChanged(object? sender, PropertyChangedEventArgs e)
Expand Down
6 changes: 3 additions & 3 deletions src/Files.App/Helpers/Dialog/DynamicDialogFactory.cs
Original file line number Diff line number Diff line change
Expand Up @@ -405,13 +405,13 @@ public static DynamicDialog GetFor_CreateAlternateDataStreamDialog()
return dialog;
}

public static async Task ShowFor_IDEErrorDialog(string path)
public static async Task ShowFor_IDEErrorDialog(string friendlyName)
{
var commands = Ioc.Default.GetRequiredService<ICommandManager>();
var dialog = new DynamicDialog(new DynamicDialogViewModel()
{
TitleText = string.Format(Strings.IDENotLocatedTitle.GetLocalizedResource(), path),
SubtitleText = Strings.IDENotLocatedContent.GetLocalizedResource(),
TitleText = Strings.IDENotLocatedTitle.GetLocalizedResource(),
SubtitleText = string.Format(Strings.IDENotLocatedContent.GetLocalizedResource(), friendlyName),
PrimaryButtonText = Strings.OpenSettings.GetLocalizedResource(),
SecondaryButtonText = Strings.Close.GetLocalizedResource(),
DynamicButtons = DynamicDialogButtons.Primary | DynamicDialogButtons.Secondary,
Expand Down
4 changes: 2 additions & 2 deletions src/Files.App/Strings/en-US/Resources.resw
Original file line number Diff line number Diff line change
Expand Up @@ -4056,10 +4056,10 @@
<value>Test</value>
</data>
<data name="IDENotLocatedContent" xml:space="preserve">
<value>The configured IDE cannot be located. Please update the path and try again.</value>
<value>{0} could not be located. Please check your settings and try again.</value>
</data>
<data name="IDENotLocatedTitle" xml:space="preserve">
<value>{0} could not be located</value>
<value>The configured IDE could not be located</value>
</data>
<data name="OpenSettings" xml:space="preserve">
<value>Open settings</value>
Expand Down

0 comments on commit 1420b70

Please sign in to comment.