Skip to content

Add null check #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add null check #61

wants to merge 3 commits into from

Conversation

hannahhoward
Copy link
Contributor

Goals

Fix this error from sentry, as a fail against all attempts with fetchCIDwithRace can produce a log without a URL https://filecoin-saturn.sentry.io/issues/4875898271/?project=4505902296858624&query=is%3Aunresolved&referrer=issue-stream&statsPeriod=14d&stream_index=0

Implementation

Add null check

@hannahhoward
fix(client): add null check
237d985 
fixes thrown exception witnessed in browser client
joaosa
joaosa approved these changes Feb 25, 2024
View reviewed changes
Copy link

@joaosa joaosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@joaosa joaosa joaosa approved these changes

@AmeanAsad AmeanAsad AmeanAsad approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hannahhoward @joaosa @AmeanAsad @gammazero