Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: release Lotus node|miner v1.30.0 #12678

Merged
merged 6 commits into from
Nov 7, 2024
Merged

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Nov 6, 2024

Related Issues

#12480

Proposed Changes

Update changelog and versions for v1.30.0.

Additional Info

Opened the same changes #12677, but for some reason that never created the draft releases automatically

Checklist

Before you mark the PR ready for review, please make sure that:

bump versions to v1.30.0 and run `make gen` and `make docsgen-cli`
chore: update changelog for v1.30.0
chore: update changelog
@rjan90 rjan90 added the skip/changelog This change does not require CHANGELOG.md update label Nov 6, 2024
@rjan90
Copy link
Contributor Author

rjan90 commented Nov 6, 2024

Hmmm... It seems like Build miner (macos-13) is also failing on this PR: https://github.com/filecoin-project/lotus/actions/runs/11707006213/job/32605452603?pr=12678, not sure if we can skip this check and just publish the tags manually? Or if this is worth looking into more deeply?

@masih
Copy link
Member

masih commented Nov 6, 2024

if we can skip this check and just publish the tags manually? Or if this is worth looking into more deeply?

I think we should take a closer look. I am not sure why it is failing.

@rjan90
Copy link
Contributor Author

rjan90 commented Nov 6, 2024

I think we should take a closer look. I am not sure why it is failing.

Pushed a test where I downgraded Filecoin-FFI to v1.30.0-rc2, just to see if that is where the issue lies

@masih
Copy link
Member

masih commented Nov 6, 2024

Pushed a test where I downgraded Filecoin-FFI to v1.30.0-rc2, just to see if that is where the issue lies

It's not looking any better. I wonder if something has changed in the github actions runners?

@rjan90 rjan90 force-pushed the phi/prep-v1300-stable branch from 1e13aa6 to 401a395 Compare November 7, 2024 01:55
@Stebalien
Copy link
Member

We shouldn't even be building the FFI here, we should be using pre-built assets. I think the issue is that we're trying to build a universal binary on macos-13 (x86) when we usually build on macos-latest (macos-14).

@Stebalien
Copy link
Member

2024-11-06T15:46:32.8483500Z + echo '[download_release_tarball] failed to determine release tag'
2024-11-06T15:46:32.8484670Z [download_release_tarball] failed to determine release tag

We need submoule tags to be able to fetch the pre-built FFI.
@Stebalien Stebalien force-pushed the phi/prep-v1300-stable branch from b511167 to 82152d4 Compare November 7, 2024 02:58
@Stebalien Stebalien mentioned this pull request Nov 7, 2024
8 tasks
@rjan90
Copy link
Contributor Author

rjan90 commented Nov 7, 2024

@rjan90 rjan90 merged commit 9c1964e into release/v1.30.0 Nov 7, 2024
93 checks passed
@rjan90 rjan90 deleted the phi/prep-v1300-stable branch November 7, 2024 03:44
@masih
Copy link
Member

masih commented Nov 7, 2024

We shouldn't even be building the FFI here, we should be using pre-built assets.

Yeah 👍 but what changed since the last release?

rjan90 added a commit that referenced this pull request Nov 7, 2024
* chore: bump version to v1.30.0

bump versions to v1.30.0 and run `make gen` and `make docsgen-cli`

* chore: update changelog for v1.30.0

chore: update changelog for v1.30.0

* chore: update changelog

chore: update changelog

* fix(ci): fetch tags

We need submoule tags to be able to fetch the pre-built FFI.

* chore: add upgrade epoch and time to changelog

chore: add upgrade epoch and time to changelog

---------

Co-authored-by: Steven Allen <[email protected]>
rjan90 added a commit that referenced this pull request Nov 7, 2024
* chore: bump version to v1.30.0

bump versions to v1.30.0 and run `make gen` and `make docsgen-cli`

* chore: update changelog for v1.30.0

chore: update changelog for v1.30.0

* chore: update changelog

chore: update changelog

* fix(ci): fetch tags

We need submoule tags to be able to fetch the pre-built FFI.

* chore: add upgrade epoch and time to changelog

chore: add upgrade epoch and time to changelog

---------

Co-authored-by: Steven Allen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does not require CHANGELOG.md update
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging this pull request may close these issues.

3 participants