fix(events): load actor from tipset state, not parent state #11945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
commented
Apr 30, 2024
node/impl/full/eth_events.go
Outdated
Comment on lines
121
to
132
| ts, err := sa.Chain.GetTipSetFromKey(ctx, ev.TipSetKey) | ||
| if err != nil { | ||
| return nil, xerrors.Errorf("loading tipset: %w", err) | ||
| } | ||
| stateRoot, _, err := sa.StateManager.TipSetState(ctx, ts) | ||
| if err != nil { | ||
| return nil, xerrors.Errorf("loading tipset state: %w", err) | ||
| } | ||
| actor, err := sa.StateManager.LoadActorRaw(ctx, emitterAddr, stateRoot) |
There was a problem hiding this comment.
this is the relevant section that I'm testing out
The problem with sa.StateGetActor(tsk) is that it it loads ParentState but the event may arise from a tipset where the actor id was first introduced, so we fail with an "unknown actor" error. But if we fast-forward by one then it's there.
masih
force-pushed
the
masih/events-index-by-id
branch
from
9abe818 to
994fe50
Compare
rvagg
force-pushed
the
rvagg/events-index-by-id-fix
branch
from
510f015 to
57d5c86
Compare
|
see comment in https://github.com/filecoin-project/lotus/pull/11905/files#r1585930424 regarding |
rvagg
force-pushed
the
rvagg/events-index-by-id-fix
branch
from
57d5c86 to
e0d154b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR against #11723 to load state of current tipset instead of parent.