Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently use lower case for errors with no ending punctuation #796

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

masih
Copy link
Member

@masih masih commented Dec 13, 2024

Fixes #795

@masih masih requested a review from rvagg December 13, 2024 10:24
@masih masih enabled auto-merge December 13, 2024 10:24
@masih masih requested a review from rjan90 December 13, 2024 10:30
@masih masih added this pull request to the merge queue Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 6.25000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 69.39%. Comparing base (1b17c6c) to head (8d9e568).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
manifest/manifest.go 0.00% 12 Missing ⚠️
f3.go 50.00% 1 Missing ⚠️
gpbft/gpbft.go 0.00% 1 Missing ⚠️
internal/powerstore/powerstore.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #796      +/-   ##
==========================================
- Coverage   69.64%   69.39%   -0.26%     
==========================================
  Files          77       77              
  Lines        7900     7900              
==========================================
- Hits         5502     5482      -20     
- Misses       1949     1965      +16     
- Partials      449      453       +4     
Files with missing lines Coverage Δ
certstore/certstore.go 64.41% <ø> (ø)
f3.go 61.53% <50.00%> (-1.47%) ⬇️
gpbft/gpbft.go 89.12% <0.00%> (ø)
internal/powerstore/powerstore.go 61.86% <0.00%> (ø)
manifest/manifest.go 54.19% <0.00%> (ø)

... and 3 files with indirect coverage changes

Merged via the queue into main with commit 28ccfd8 Dec 13, 2024
12 of 13 checks passed
@masih masih deleted the masih/consistent-lower-case-err branch December 13, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consistently use lower case for error messages
2 participants