Fix a bug in pubsub message ID hash function

[masih]

The prior implementation I believe intended to include additional fields into account when calculating the message ID from data. But was only returning hash of data for both manifest and GPBFT messages.

Fix this by writing the data to the hasher, then computing the hash with no suffix.

[codecov]

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 69.38%. Comparing base (1b17c6c) to head (e6549d7).
Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/psutil/psutil.go	33.33%	2 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #791      +/-   ##
==========================================
- Coverage   69.64%   69.38%   -0.27%     
==========================================
  Files          77       77              
  Lines        7900     7904       +4     
==========================================
- Hits         5502     5484      -18     
- Misses       1949     1962      +13     
- Partials      449      458       +9     

Files with missing lines	Coverage Δ
internal/psutil/psutil.go	32.25% <33.33%> (+13.73%)	⬆️

... and 3 files with indirect coverage changes

[Kubuxu]

Does that mean our message IDs contained all of the data?

[Kubuxu]

Great catch!!

[masih]

Does that mean our message IDs contained all of the data?

No no. It contained only the hash of all of data.

Previously we called blake2b.Sum256 which takes a byte slice and hashes it. We then returned whatever that hash was even though earlier lines instantiated a separate hasher and wrote various values to it which were never used.

[Kubuxu]

One note is that this will break the message propagation.

[masih]

So if we want to merge this it's best to fix the tag for the container used by manifest server and observer so that they do not pull the latest 👍

[Stebalien]

That's... wow.

[masih]

We can merge this once this pr is merged: https://github.com/filecoin-project/f3-passive-testing/pull/142