-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ChainProposedLength into the manifest #788
Conversation
Signed-off-by: Jakub Sztandera <[email protected]>
Increase max length to 128 to line up with merke tree size Signed-off-by: Jakub Sztandera <[email protected]>
52c44b7
to
b344276
Compare
Signed-off-by: Jakub Sztandera <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #788 +/- ##
==========================================
- Coverage 69.55% 69.48% -0.08%
==========================================
Files 77 77
Lines 7896 7900 +4
==========================================
- Hits 5492 5489 -3
- Misses 1954 1959 +5
- Partials 450 452 +2
|
Signed-off-by: Jakub Sztandera <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might as well increment the manifest protocol version. BUT later once other changes have also landed in manifest.
Merging this as the manifest changes I am working on would make merge tricky later. |
Resolves #772