Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ChainProposedLength into the manifest #788

Merged
merged 4 commits into from
Dec 12, 2024

Conversation

Kubuxu
Copy link
Contributor

@Kubuxu Kubuxu commented Dec 11, 2024

Resolves #772

Increase max length to 128 to line up with merke tree size

Signed-off-by: Jakub Sztandera <[email protected]>
@Kubuxu Kubuxu force-pushed the feat/ec-chain-size-manifest branch from 52c44b7 to b344276 Compare December 11, 2024 14:08
Signed-off-by: Jakub Sztandera <[email protected]>
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 69.48%. Comparing base (be650d0) to head (b93a282).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
manifest/manifest.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #788      +/-   ##
==========================================
- Coverage   69.55%   69.48%   -0.08%     
==========================================
  Files          77       77              
  Lines        7896     7900       +4     
==========================================
- Hits         5492     5489       -3     
- Misses       1954     1959       +5     
- Partials      450      452       +2     
Files with missing lines Coverage Δ
consensus_inputs.go 61.45% <100.00%> (-1.47%) ⬇️
gpbft/chain.go 87.87% <ø> (ø)
manifest/manifest.go 54.19% <0.00%> (-1.07%) ⬇️

... and 1 file with indirect coverage changes

gpbft/chain.go Show resolved Hide resolved
Signed-off-by: Jakub Sztandera <[email protected]>
Copy link
Member

@masih masih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might as well increment the manifest protocol version. BUT later once other changes have also landed in manifest.

@masih
Copy link
Member

masih commented Dec 12, 2024

Merging this as the manifest changes I am working on would make merge tricky later.

@masih masih added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit 1b17c6c Dec 12, 2024
12 of 13 checks passed
@masih masih deleted the feat/ec-chain-size-manifest branch December 12, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make maximum chain length configurable in manifest
2 participants