Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement cert chain generator/verifier from EC #775

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

masih
Copy link
Member

@masih masih commented Dec 3, 2024

Implement testing utilities to:

  • generate random finality certificate chain given an ec.Backend
  • verify conformity of an existing chain with a given ec.Backend

Fixes #743

@masih masih requested review from rvagg and Kubuxu December 3, 2024 16:03
Implement testing utilities to:
* generate random finality certificate chain given an `ec.Backend`
* verify conformity of an existing chain with a given  `ec.Backend`

Fixes #743
@masih masih force-pushed the masih/certchain-gen-verify branch from fea77fb to bc06f9a Compare December 3, 2024 16:10
@Kubuxu
Copy link
Contributor

Kubuxu commented Dec 3, 2024

Very rough review, but LGTM.

@Stebalien
Copy link
Member

Nit: put this into an internal package?

@masih
Copy link
Member Author

masih commented Dec 3, 2024

Nit: put this into an internal package?

I need to use it in lotus to verify the cert chain of a network, e.g. calibnet.
Because lotus ec.Backend implementation lives in Lotus.

@masih masih added this pull request to the merge queue Dec 3, 2024
@Stebalien
Copy link
Member

Ah, I see. We're trying to unify our testing code and our actual code. Makes sense.

Merged via the queue into main with commit 8053a8f Dec 3, 2024
11 checks passed
@masih masih deleted the masih/certchain-gen-verify branch December 3, 2024 17:09
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 64.10256% with 112 lines in your changes missing coverage. Please review.

Project coverage is 69.27%. Comparing base (b4e2522) to head (bc06f9a).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
certchain/certchain.go 62.81% 70 Missing and 33 partials ⚠️
certchain/options.go 74.28% 6 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #775      +/-   ##
==========================================
- Coverage   69.82%   69.27%   -0.56%     
==========================================
  Files          74       76       +2     
  Lines        7557     7869     +312     
==========================================
+ Hits         5277     5451     +174     
- Misses       1869     1965      +96     
- Partials      411      453      +42     
Files with missing lines Coverage Δ
certchain/options.go 74.28% <74.28%> (ø)
certchain/certchain.go 62.81% <62.81%> (ø)

... and 5 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants