Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc test improvments #407

Merged
merged 7 commits into from
Jul 5, 2024
Merged

Misc test improvments #407

merged 7 commits into from
Jul 5, 2024

Conversation

Kubuxu
Copy link
Contributor

@Kubuxu Kubuxu commented Jul 5, 2024

No description provided.

@Kubuxu Kubuxu force-pushed the fix/pubsub-race branch 2 times, most recently from 2bd9aaf to acb727f Compare July 5, 2024 10:25
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.02%. Comparing base (b262121) to head (d34806b).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #407      +/-   ##
==========================================
- Coverage   79.09%   79.02%   -0.07%     
==========================================
  Files          36       36              
  Lines        3473     3500      +27     
==========================================
+ Hits         2747     2766      +19     
- Misses        453      459       +6     
- Partials      273      275       +2     
Files Coverage Δ
ec/fake_ec.go 83.11% <100.00%> (+0.22%) ⬆️
host.go 64.80% <100.00%> (+0.73%) ⬆️

... and 3 files with indirect coverage changes

@Kubuxu Kubuxu requested review from masih and Stebalien July 5, 2024 11:28
Copy link

github-actions bot commented Jul 5, 2024

Fuzz test failed on commit 7c8cac9. To troubleshoot locally, download the seed corpus using GitHub CLI by running:

gh run download 9807622756 -n testdata

Alternatively, download directly from here.

test/util_norace_test.go Outdated Show resolved Hide resolved
@Kubuxu Kubuxu force-pushed the fix/pubsub-race branch from 47b0609 to d34806b Compare July 5, 2024 11:59
@Kubuxu Kubuxu changed the title Fix race when pubsub is swapped over Misc test improvments Jul 5, 2024
@Kubuxu Kubuxu enabled auto-merge July 5, 2024 12:00
@Kubuxu Kubuxu added this pull request to the merge queue Jul 5, 2024
Merged via the queue into main with commit 3f20d36 Jul 5, 2024
9 of 10 checks passed
@Kubuxu Kubuxu deleted the fix/pubsub-race branch July 5, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants