Maybe fix spurious error in tests #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Race tests will sometimes fail here, there exists ordering of goroutine execution where ctx.Done() fires firt with Runner and returns here. Signed-off-by: Jakub Sztandera <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #402 +/- ##
==========================================
- Coverage 79.30% 78.95% -0.35%
==========================================
Files 27 36 +9
Lines 2880 3474 +594
==========================================
+ Hits 2284 2743 +459
- Misses 365 457 +92
- Partials 231 274 +43 |
Stebalien
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Race tests will sometimes fail here, there exists ordering of goroutine
execution where ctx.Done() fires first within Runner and propagates through the errCh and select picks it over the context.