[WIP] feat: market 2.0 #508
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snadrus
reviewed
May 14, 2025
| pqBatchSize := 20000 | ||
|
|
||
| for k, _ := range toDownload { | ||
| pqBatch.Queue(`SELECT id FROM parked_pieces WHERE piece_cid = $1 AND piece_padded_size = $2`, k.PieceCID.String(), int64(k.Size)).QueryRow(func(row pgx.Row) error { |
There was a problem hiding this comment.
Here's a hack to make this 1 query total (no loop) with half the params:
SELECT id FROM parked_pieces WHERE CONCAT(piece_cid, STRING(piece_padded_size)) = ANY($1)
snadrus
reviewed
May 14, 2025
| } | ||
| } | ||
|
|
||
| func insertPiecesInTransaction(ctx context.Context, tx *harmonydb.Tx, deal *mk20.Deal) error { |
There was a problem hiding this comment.
consider adding batch-with-flush behavior, maybe keyed on the length of args list staying low (10,000)
snadrus
reviewed
May 14, 2025
| if data.SourceHTTP != nil { | ||
| var pieceID int64 | ||
| // Attempt to select the piece ID first | ||
| err = tx.QueryRow(`SELECT id FROM parked_pieces WHERE piece_cid = $1 AND piece_padded_size = $2`, data.PieceCID.String(), data.Size).Scan(&pieceID) |
magik6k
reviewed
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write deal validation logic testsTests: