Repository navigation
feat: add upload folder command and improvs - #501
Closed
lordshashank wants to merge 1 commit into
Closed
lordshashank wants to merge 1 commit into
lordshashank wants to merge 1 commit into
Conversation
LexLuthr
reviewed
Apr 29, 2025
LexLuthr
reviewed
Apr 29, 2025
Comment on lines
+364
to
+371
| Flags: []cli.Flag{ | ||
| &cli.IntFlag{ | ||
| Name: "valid-time", | ||
| Usage: "Validity time of the JWT token in hours", | ||
| Value: 24, // Default to 1 day | ||
| }, | ||
| }, |
Collaborator
There was a problem hiding this comment.
Wouldn't this always set the JWT validity to 24 hours by default? I am not sure how PDP works but this means that JWT token handed off to SP will no longer be valid after 24 hours. How will client check anything after that?
Contributor
Author
There was a problem hiding this comment.
I also don't know, but i created one for month and it is rendering me data until now.
…dity time and enhance upload file and folder command with optional addRootsCommand
lordshashank
force-pushed
the
feat/pdp-upload-folder
branch
from
April 29, 2025 14:34
7c78d34 to
5057bf8
Compare
Collaborator
|
Closing this as we are moving away from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uploadFolderCLI command, which recursively uploads all the files in folders to pdpservice.valid-timefor jwt creation and defaults it to 24 hours.addRootsparameter touploadFileanduploadFoldercommand to upload and add root of particular file/folder in one go rather than running separate commands.Future improvs:-
POSTcall to pdp-miner has some bugs i.e. is not working properly, hence currently makes multiple request for each roots.