Repository navigation
feat: use consts for addrs - #660
Merged
Merged
Conversation
And expose actor IDs so we don't need to call `.id().unwrap()` to retrieve them.
Stebalien
force-pushed
the
feat/const-addrs
branch
from
September 15, 2022 20:16
3c7e602 to
af836ea
Compare
Member
Author
|
(happy to punt this if we don't want to do it now, it was just annoying me a bit) |
Stebalien
commented
Sep 15, 2022
| macro_rules! define_singletons { | ||
| ($($name:ident = $id:literal,)*) => { | ||
| $( | ||
| paste! { |
Member
Author
There was a problem hiding this comment.
This won't have any affect at runtime, it just allows us to concatenate identifiers at compile time.
ZenGround0
approved these changes
Sep 15, 2022
Member
Author
Rust thinks |
anorth
reviewed
Sep 15, 2022
anorth
left a comment
anorth
left a comment
Member
There was a problem hiding this comment.
LGTM apart from the unused import thing. I would also be just as happy with a version that didn't use the macro.
Member
Author
@mriise found the issue and is pushing a fix |
Contributor
|
we also had a workaround for serde, which was fixed in rust-lang/rust#89738. that is now gone |
Stebalien
added a commit
that referenced
this pull request
Sep 16, 2022
* feat: use consts for addrs And expose actor IDs so we don't need to call `.id().unwrap()` to retrieve them. Co-authored-by: mriise <me@mriise.net>
Stebalien
added a commit
that referenced
this pull request
Sep 16, 2022
* feat: use consts for addrs And expose actor IDs so we don't need to call `.id().unwrap()` to retrieve them. Co-authored-by: mriise <me@mriise.net>
shamb0
pushed a commit
to shamb0/builtin-actors
that referenced
this pull request
Jan 31, 2023
* feat: use consts for addrs And expose actor IDs so we don't need to call `.id().unwrap()` to retrieve them. * remove old TODO and extern crate refs Co-authored-by: mriise <me@mriise.net>
snissn
pushed a commit
to snissn/builtin-actors
that referenced
this pull request
Apr 11, 2025
* Add FIP proposal for WindowPoSt Grindability Fix * Update fip-00xx.md to include the existing discussion link * Apply some review feedback * Apply jake's feedback * Update the header to the proper template style * Apply review feedback * Update fip-00xx.md * Rename FIP to the assigned number * Apply review feedback * Flesh out details of the two-phase network upgrade --------- Co-authored-by: DrPeterVanNostrand <jnz@riseup.net> Co-authored-by: Kaitlin Beegle <46908964+kaitlin-beegle@users.noreply.github.com> Co-authored-by: Aayush <arajasek94@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And expose actor IDs so we don't need to call
.id().unwrap()to retrieve them.