Skip to content

chore: rm dead code Reward struct - #1777

Merged
LesnyRumcajs merged 1 commit into
masterfrom
rm-dead-amount-vested
Aug 12, 2026
Merged

chore: rm dead code Reward struct#1777
LesnyRumcajs merged 1 commit into
masterfrom
rm-dead-amount-vested

Conversation

@LesnyRumcajs

Copy link
Copy Markdown
Contributor

Reward struct is effectively dead code. In theory in the public API... but

  • Without any tests (and some unsound logic)
  • The only consumer is (AFAIK) Forest's versioned fork of actors...
  • ... which Forest doesn't even use.

I don't think it was ever used anywhere.

@LesnyRumcajs
LesnyRumcajs requested a review from rvagg as a code owner August 11, 2026 16:44
Copilot AI lite review requested due to automatic review settings August 11, 2026 16:44
@github-project-automation github-project-automation Bot moved this to 📌 Triage in FilOz Aug 11, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the unused Reward/VestingFunction types from the reward actor crate, reducing dead public API surface area that appears to have no in-repo consumers.

Changes:

  • Deleted the Reward struct and VestingFunction enum from actors/reward/src/state.rs.
  • Removed the public re-export of those types from actors/reward/src/lib.rs.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
actors/reward/src/state.rs Removes the unused Reward/VestingFunction definitions and related imports.
actors/reward/src/lib.rs Stops re-exporting the removed types from the crate’s public API.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread actors/reward/src/lib.rs
Comment on lines 17 to 19
pub use self::logic::*;
pub use self::state::{Reward, State, VestingFunction};
pub use self::state::State;
pub use self::types::*;
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.58%. Comparing base (6094683) to head (47e5b87).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1777      +/-   ##
==========================================
+ Coverage   90.55%   90.58%   +0.02%     
==========================================
  Files         140      140              
  Lines       27814    27805       -9     
==========================================
  Hits        25186    25186              
+ Misses       2628     2619       -9     
Files with missing lines Coverage Δ
actors/reward/src/lib.rs 84.48% <ø> (ø)
actors/reward/src/state.rs 94.73% <ø> (+12.91%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-project-automation github-project-automation Bot moved this from 📌 Triage to ✔️ Approved by reviewer in FilOz Aug 12, 2026
@LesnyRumcajs
LesnyRumcajs added this pull request to the merge queue Aug 12, 2026
Merged via the queue into master with commit 5a38002 Aug 12, 2026
13 checks passed
@LesnyRumcajs
LesnyRumcajs deleted the rm-dead-amount-vested branch August 12, 2026 06:28
@github-project-automation github-project-automation Bot moved this from ✔️ Approved by reviewer to 🎉 Done in FilOz Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

4 participants