chore: rm dead code Reward struct - #1777
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the unused Reward/VestingFunction types from the reward actor crate, reducing dead public API surface area that appears to have no in-repo consumers.
Changes:
- Deleted the
Rewardstruct andVestingFunctionenum fromactors/reward/src/state.rs. - Removed the public re-export of those types from
actors/reward/src/lib.rs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| actors/reward/src/state.rs | Removes the unused Reward/VestingFunction definitions and related imports. |
| actors/reward/src/lib.rs | Stops re-exporting the removed types from the crate’s public API. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
17
to
19
| pub use self::logic::*; | ||
| pub use self::state::{Reward, State, VestingFunction}; | ||
| pub use self::state::State; | ||
| pub use self::types::*; |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1777 +/- ##
==========================================
+ Coverage 90.55% 90.58% +0.02%
==========================================
Files 140 140
Lines 27814 27805 -9
==========================================
Hits 25186 25186
+ Misses 2628 2619 -9
🚀 New features to boost your workflow:
|
rvagg
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewardstruct is effectively dead code. In theory in the public API... butI don't think it was ever used anywhere.