Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji: Add comments about no-longer-in-use code path. #25

Merged
merged 1 commit into from
Mar 28, 2024
+7 −3
Merged

Emoji: Add comments about no-longer-in-use code path. #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/emoji-mart/src/components/Emoji/Emoji.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,10 @@ export default function Emoji(props) {
</span>
)
}

// TODO: Before enabling `emoji_15_upgrade`, we will need to update this to respect the new
// URL format for emoji images in Figma Design and Figjam (which will likely be using Noto).
// As of writing, we only use this function with the 'native' emoji set, so all
// code below is effectively deprecated. If using this code path again,
// Images.getUrl will have to be updated to return the currently in use URLs
// used in the Figma product.

const src = Images.getUrl(emojiSkin)
return (
Expand Down
3 changes: 3 additions & 0 deletions packages/emoji-mart/src/helpers/images.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
// At writing, this URL is not in use. If it is used again,
// it will need to be updated appropriately to the most
// recent figma-hosted emoji URL base.
const URL = 'https://static.figma.com/emoji/4/64/'

function getUrl(emojiSkin) {
Expand Down
Loading