emoji-mart: expose NativeSupport tools #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ethods to infer what version of emojis are supported
oliw-figma
commented
Nov 16, 2023
| @@ -1,5 +1,5 @@ | |||
| export { PickerElement as Picker } from './components/Picker' | |||
| export { EmojiElement as Emoji } from './components/Emoji' | |||
|
|
|||
| export { SearchIndex, Store } from './helpers' | |||
| export { SearchIndex, Store, NativeSupport } from './helpers' | |||
There was a problem hiding this comment.
Check out https://github.com/figma/emoji-mart/blob/figma-release-3/packages/emoji-mart/src/helpers/native-support.js to see what I'm exporting
sam-dixon
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several (somewhat standardized) "Emoji" sets out there; we at Figma currently target Emoji 14; however some people use Figma using older operating systems (with older font libraries) don't support Emoji 14 (e.g. my older personal macbook pro which is on Mac OS 11).
EmojiMart's
<Picker/>component has aversionprop you can pass in. When set, it will only show you emojis to pick that are<=the version you provided.We don't current set it, so it defaults to 14.
When I open our Picker on my personal laptop I see some ugly un-renderable emojis :(
This PR exposes the NativeSupport helper library so that clients can use its methods to infer what version of emojis are supported and thus set the version library appropriately.