Skip to content

Commit

Permalink
Emoji: Add comments about no-longer-in-use code path. (#25)
Browse files Browse the repository at this point in the history
  • Loading branch information
ngainsboro-figma authored Mar 28, 2024
1 parent 3f99397 commit 703b22e
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
7 changes: 4 additions & 3 deletions packages/emoji-mart/src/components/Emoji/Emoji.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,10 @@ export default function Emoji(props) {
</span>
)
}

// TODO: Before enabling `emoji_15_upgrade`, we will need to update this to respect the new
// URL format for emoji images in Figma Design and Figjam (which will likely be using Noto).
// As of writing, we only use this function with the 'native' emoji set, so all
// code below is effectively deprecated. If using this code path again,
// Images.getUrl will have to be updated to return the currently in use URLs
// used in the Figma product.

const src = Images.getUrl(emojiSkin)
return (
Expand Down
3 changes: 3 additions & 0 deletions packages/emoji-mart/src/helpers/images.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
// At writing, this URL is not in use. If it is used again,
// it will need to be updated appropriately to the most
// recent figma-hosted emoji URL base.
const URL = 'https://static.figma.com/emoji/4/64/'

function getUrl(emojiSkin) {
Expand Down

0 comments on commit 703b22e

Please sign in to comment.