Skip to content

fix: take correct strategies#123

Merged
kaushik-himself merged 2 commits into
mainfrom
vk/fix
Jun 3, 2025
Merged

fix: take correct strategies#123
kaushik-himself merged 2 commits into
mainfrom
vk/fix

Conversation

@vinikatyal

@vinikatyal vinikatyal commented Jun 3, 2025

Copy link
Copy Markdown
Contributor

Description

It wasnt taking the updated strategies,

How to reproduce

  1. Create a new config
  2. Run test with selected strategies
  3. Append new strategies to the existing ones
  4. It wasn't working with the new strategies

Screenshots/Results

  • Add a screenshot of the changes or code responses

Reference Links

  • Links to JIRA issue, links, Slack discussions, etc.

Checklist

This PR includes the following (tick all that apply):

  • Tests added/updated for new/changed functionality
  • Bug Fix (explain the bug in the description)
  • Refactoring or optimizations (no functional changes)
  • Documentation updated (README, docstrings, etc.)
  • Build or deployment related changes
  • Dependency updates (requirements.txt/pyproject.toml)
  • Setup change (update README/setup instructions if required)
  • Code style checks passed (PEP8, flake8, black, etc.)
  • Type hints added/updated (if applicable)
  • Pre-commit hooks run (if configured)

Comment thread ui/dashboard.py

if submit_button:
if not prompt.strip():
st.error("🚫 Please enter a prompt!")

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaushik-himself this check is happening twice

@kaushik-himself

Copy link
Copy Markdown
Contributor

can you add a description of the bug, its root cause, fix, and the way in which the fix was tested to the PR description?

@kaushik-himself kaushik-himself merged commit c9dfff3 into main Jun 3, 2025
3 checks passed
@kaushik-himself kaushik-himself deleted the vk/fix branch June 3, 2025 16:37
@vinikatyal

Copy link
Copy Markdown
Contributor Author

can you add a description of the bug, its root cause, fix, and the way in which the fix was tested to the PR description?
Added
How to reproduce

  1. Create a new config
  2. Run test with selected strategies
  3. Append new strategies to the existing ones
  4. It wasn't working with the new strategies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants