Skip to content

Update SwiftFormat rules to properly format decimal numbers #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 1, 2025

Conversation

graycampbell
Copy link
Collaborator

📝 Summary

  • Added --decimalgrouping option to .swiftformat to fix how decimal numbers are formatted.

🛠️ Type of Change

  • Bug fix (change that fixes an issue)
  • New feature (change that adds functionality)
  • Breaking change (bug fix or feature that is not backwards compatible)
  • Documentation (DocC, API docs, markdown files, templates, etc.)
  • Testing (new tests, updated tests, etc.)
  • Refactoring or code formatting (no logic changes)
  • Updating dependencies (Swift packages, Homebrew, etc.)
  • CI/CD (change to automated workflows)
  • Chore (other maintenance)

🧪 How Has This Been Tested?

  • All existing tests pass.

✅ Checklist

  • I have added relevant tests
  • I have verified all tests pass
  • I have formatted my code using SwiftFormat
  • I have updated documentation (if needed)
  • I have added the appropriate label to my PR
  • I have read the contributing guidelines
  • I agree to follow this project's Code of Conduct

@graycampbell graycampbell self-assigned this Jul 28, 2025
@graycampbell graycampbell added the formatting Changes related to code formatting label Jul 28, 2025
@graycampbell graycampbell force-pushed the formatting/decimal-grouping branch from ad97739 to 7999dfd Compare July 28, 2025 15:18
@graycampbell graycampbell requested review from a team, Yurssoft, ghaisasavanti, ben-fortier, Jacob-Starry, bfahey, pjtnt11 and nolinmcfarland and removed request for a team July 28, 2025 15:34
@graycampbell graycampbell marked this pull request as ready for review July 28, 2025 15:34
Base automatically changed from bugfix/mock-does-not-properly-record-simultaneous-input to main July 28, 2025 19:53
@graycampbell graycampbell force-pushed the formatting/decimal-grouping branch from 5e648df to d2458a3 Compare July 28, 2025 19:55
Copy link

codecov bot commented Jul 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.65%. Comparing base (8a1acea) to head (d2458a3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #123   +/-   ##
=======================================
  Coverage   69.65%   69.65%           
=======================================
  Files          73       73           
  Lines        4811     4811           
=======================================
  Hits         3351     3351           
  Misses       1460     1460           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@graycampbell graycampbell merged commit 68c4ead into main Aug 1, 2025
7 checks passed
@graycampbell graycampbell deleted the formatting/decimal-grouping branch August 1, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
formatting Changes related to code formatting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants