Allows to enable/disable keyboard control, fixes issue of unwanted focus ring in macOS 14+#330
Open
peterpaulis wants to merge 5 commits intofermoya:mainfrom
Open
Allows to enable/disable keyboard control, fixes issue of unwanted focus ring in macOS 14+#330peterpaulis wants to merge 5 commits intofermoya:mainfrom
peterpaulis wants to merge 5 commits intofermoya:mainfrom
Conversation
fixing fermoya#329
version bump
|
Curious how does this PR solve the focus ring issue? |
Author
Simply by giving the option to disable keyboard control… without keyboard control, the focus ring doesnt appear |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #329 by using the new modifier .allowsKeyboardControl(false)