Skip to content

[DEV-15434] Added check for Recipient Count View#4688

Merged
DavidMikolaKC merged 5 commits into
qatfrom
bug/dev-15434-filter-empty-request-bodies
Jul 14, 2026
Merged

[DEV-15434] Added check for Recipient Count View#4688
DavidMikolaKC merged 5 commits into
qatfrom
bug/dev-15434-filter-empty-request-bodies

Conversation

@DavidMikolaKC

@DavidMikolaKC DavidMikolaKC commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Description:

The RecipientCount view from list_recipients.py only reads data from the API request’s body before caching, however the cache.py helper accepts parameters from the request body and the query parameters. This means that someone can send an API request to the RecipientCount endpoint with a query parameter, but no request body, causing an unfiltered search to be done and cached. The problem is that even though the result was completely unfiltered, it would be cached with the query parameter causing future requests (with the same filter in the body instead of query parameters) to be returned incorrectly.

Technical Details:

The Recipient Count View only reads the request body. The cache function has been updated as to not take into account the query parameters for that view.

Requirements for PR Merge:

  1. Unit & integration tests updated
  2. API documentation updated (examples listed below)
    1. API Contracts
    2. API UI
    3. Comments
  3. Data validation completed (examples listed below)
    1. Does this work well with the current frontend? Or is the frontend aware of a needed change?
    2. Is performance impacted in the changes (e.g., API, pipeline, downloads, etc.)?
    3. Is the expected data returned with the expected format?
  4. Appropriate Operations ticket(s) created
  5. Jira Ticket(s)
    1. DEV-15434

Explain N/A in above checklist:

@DavidMikolaKC DavidMikolaKC self-assigned this Jul 8, 2026
@DavidMikolaKC DavidMikolaKC added do not merge [PR] shouldn't be merged in progress [ISSUE | PR] being worked labels Jul 8, 2026
@DavidMikolaKC DavidMikolaKC removed the do not merge [PR] shouldn't be merged label Jul 13, 2026
aguest-kc
aguest-kc previously approved these changes Jul 14, 2026
@aguest-kc
aguest-kc dismissed their stale review July 14, 2026 13:32

Accidentally approved before my review was complete.

@DavidMikolaKC
DavidMikolaKC merged commit 90bbafe into qat Jul 14, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in progress [ISSUE | PR] being worked

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants