[DEV-15434] Added check for Recipient Count View#4688
Merged
Conversation
aguest-kc
previously approved these changes
Jul 14, 2026
aguest-kc
dismissed
their stale review
July 14, 2026 13:32
Accidentally approved before my review was complete.
aguest-kc
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The RecipientCount view from list_recipients.py only reads data from the API request’s body before caching, however the cache.py helper accepts parameters from the request body and the query parameters. This means that someone can send an API request to the RecipientCount endpoint with a query parameter, but no request body, causing an unfiltered search to be done and cached. The problem is that even though the result was completely unfiltered, it would be cached with the query parameter causing future requests (with the same filter in the body instead of query parameters) to be returned incorrectly.
Technical Details:
The Recipient Count View only reads the request body. The cache function has been updated as to not take into account the query parameters for that view.
Requirements for PR Merge:
Explain N/A in above checklist: