Correctly handle riscv64 chroots#1899
Merged
kwk merged 1 commit intofedora-llvm-team:mainfrom Jan 29, 2026
Merged
Conversation
nikic
reviewed
Jan 28, 2026
|
|
||
| >>> allowed_archs_as_regex_str() | ||
| '(aarch64|i386|ppc64le|s390x|x86_64)' | ||
| '(aarch64|i386|ppc64le|s390x|x86_64|riscv64|x86_64_v2)' |
Collaborator
There was a problem hiding this comment.
Does allowed_archs need to be updated as well?
Also, what effect is this going to have? Are we doing to start building for these chroots as well?
Collaborator
Author
There was a problem hiding this comment.
I was lazy and only ran the tests on github. Sorry, you're right. I need to update that as well. Let me check if the sanitization filters them out.
Collaborator
Author
There was a problem hiding this comment.
@nikic can you please recheck? I've modified the chroot sanitization to exclude all riscv64 chroots for now. The x86_64_v2 wasn't an error so far but I simply saw the architecture pop up. Should we run into problems with it we need to handle it as well I've removed it from this PR.
kwk
force-pushed
the
add-riscv64-and-x86_64_v2-as-chroot-archs
branch
from
b3badc7 to
c3c1dca
Compare
* Add missing arch to allowed_archs_as_regex_str The `chroot_pattern` in `config.py` couldn't be filtered to remove `riscv64` chroots before this patch because it thought that is was an unknown architecture. * While riscv64 indeed IS a known architecutre now, we still don't want to build for it. When sanitizing the chroots to be used in the config we remove all riscv64 chroots.
kwk
force-pushed
the
add-riscv64-and-x86_64_v2-as-chroot-archs
branch
from
c3c1dca to
30562f7
Compare
kwk
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing arch to allowed_archs_as_regex_str
The
chroot_patterninconfig.pycouldn't be filtered to removeriscv64chroots before this patch becauseit thought that is was an unknown architecture.
While riscv64 indeed IS a known architecutre now,
we still don't want to build for it.
When sanitizing the chroots to be used in the config
we remove all riscv64 chroots.