navigation link between logs and minutes #712
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: freedisch <[email protected]>
|
I have access now to the logs, I will test my changes and check if there is anything else to fix |
|
Everything looks good, here is a full demo Screen.Recording.2024-04-28.at.23.52.01.mov |
keszybz
approved these changes
Jul 14, 2024
| @@ -133,6 +135,7 @@ def statfile(channame, cldrdate, meetname, typecont): | |||
| timetext=meeting_title.group(3), | |||
| typecont=typecont, | |||
| meetcont=meetcont[1], | |||
| url_type=url_type | |||
| <span class="float-left"><i class="fas fa-link"></i></span> | ||
| <span class="float-right"><a href="{{ url_type }}">Logs</a></span> | ||
| </li> | ||
| {% elif typecont == "Logs"%} |
There was a problem hiding this comment.
Space missing here before "%".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request fix issue #684
This PR addresses a request of a more seamless navigation experience between the minutes summary and the full meeting logs of a particular meeting.
PS: the meetbot logs archive is not working link, I couldn't access to the page to make a demo.