Fix indicating waived failures when there is no scenario #5863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tested this by doing a local script override on the affected update - https://bodhi.fedoraproject.org/updates/FEDORA-2025-68042562fc - and with this change overridden into place, it correctly shows the thumbsup icon with tooltip. |
On the Automated Tests tab, when a required test failed but the failure has been waived, we intend to show a thumbs-up icon with a tooltip with details about the waiver. However, if the failed test has no 'scenario', this doesn't work, because there's a hash key mismatch (we store the waiver under key "testcase##null" but look it up under key "testcase##no_scenario"). This should fix that, and mean we correctly note waived failures for Fedora CI results (openQA ones always have a scenario). Signed-off-by: Adam Williamson <[email protected]>
AdamWill
force-pushed
the
fix-waiver-display-when-no-scenario
branch
from
2f7a3e7 to
683a724
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the Automated Tests tab, when a required test failed but the failure has been waived, we intend to show a thumbs-up icon with a tooltip with details about the waiver. However, if the failed test has no 'scenario', this doesn't work, because there's a hash key mismatch (we store the waiver under key "testcase##null" but look it up under key "testcase##no_scenario").
This should fix that, and mean we correctly note waived failures for Fedora CI results (openQA ones always have a scenario).