Poll error callbacks#669
Closed
ignytis wants to merge 5 commits intofede1024:masterfrom
ignytis:poll_error_callbacks
Closed
Poll error callbacks#669ignytis wants to merge 5 commits intofede1024:masterfrom ignytis:poll_error_callbacks
ignytis wants to merge 5 commits intofede1024:masterfrom
ignytis:poll_error_callbacks
Conversation
Sorry this is already part of the master code |
Author
|
Looks like it's implemented in #771 indeed. Anyway, thanks for pinging here, now I can close this old PR :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This PR adds a callback logic for errors occurred on
pollmethod call in producer. The idea is to handle several kinds of errors immediately.Here is a use case for this feature. If the application fails to connect or to authenticate to Kafka server then it exits with error code:
https://github.com/ignytis/send2kafka/blob/705f022beb50d8c8be77abbf6e15bd79707e9ebe/src/kafka_producer.rs#L32 <- setting the callback
https://github.com/ignytis/send2kafka/blob/705f022beb50d8c8be77abbf6e15bd79707e9ebe/src/kafka_producer.rs#L8-L13 <- callback itself
This way the connection issues might be handled before trying to send actual messages to the broker.
I'd appreciate any recommendations if there are any option to improve this code or implement this feature the other way.