fix verifyChanges causing 0: {, 1: } during insert and patch#216
Open
closertotheend wants to merge 2 commits intofeathersjs-ecosystem:masterfrom
Open
fix verifyChanges causing 0: {, 1: } during insert and patch#216closertotheend wants to merge 2 commits intofeathersjs-ecosystem:masterfrom
closertotheend wants to merge 2 commits intofeathersjs-ecosystem:masterfrom
Conversation
✅ Deploy Preview for feathers-a-m ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
Author
|
Checked locally with npm link, fix seems to be working |
Collaborator
|
Thanks for this as it seems to annoy many people. Not familiar enough with SQLite though to check if it's a valid workaround, but from a more general point of view I would ask if it would not be more "readable" and less risky (eg avoid any exception if I will let run the tests anyway to ensure it works. |
fratzinger
requested changes
Oct 16, 2023
claustres
approved these changes
Oct 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to fact that most realtional dbs do not support string[] inside single column, people cast verifyChanges to text type.
When field is deserialized from db we need to parse it twice. Otherwise Object.assign({}, '{}') will yield {0:'{', 1: '}'}
Related issue:
#206