-
Notifications
You must be signed in to change notification settings - Fork 23
Add support for rate #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Retry does not work. |
Can confirm the retry stuff works now like a charm.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Would you mind rebasing on the master branch? There's a merge conflict |
Also fixed a few other things: - bugs in active mode detection with my display (144hz and 60hz) - Turn off changed displays in a smarter way. Im using usb-c daisychain and had trouble with the current approach. it disabled my screen as soon as the screen went into hibernate because xrandr stopped detecting the display. - some autoformatting of comments and code according to efficient go guidelines - if xrand (ApplyRule) fails, try 3 times with a little more sleep each time. This also solved issues with my daisychained displays. Fixes fd0#29
@fd0 rebased on master! |
Hmm I personally dont think thats a problem. But to satisfy the linter i could make it public? ping @fd0 |
Ping @fd0 ? |
ping @fd0 |
displays Happens for example in daisy chaining usb-c to DP it always changes the number when reconnecting to the display
Hi @jonaz , are you still using this patch? May I apply it locally since it's not merged? |
Yes I use it everyday
…On Sat, 12 Apr 2025, 13:11 Valeriy Litkovskyy, ***@***.***> wrote:
Hi @jonaz <https://github.com/jonaz> , are you still using this patch?
May I apply it locally since it's not merged?
—
Reply to this email directly, view it on GitHub
<#30 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIX4FITP3IJP6DEU3OS7ZL2ZDYGLAVCNFSM6AAAAAB2Y7MFQWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOJYG44DSMZRGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
*xFA25E* left a comment (fd0/grobi#30)
<#30 (comment)>
Hi @jonaz <https://github.com/jonaz> , are you still using this patch?
May I apply it locally since it's not merged?
—
Reply to this email directly, view it on GitHub
<#30 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIX4FITP3IJP6DEU3OS7ZL2ZDYGLAVCNFSM6AAAAAB2Y7MFQWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOJYG44DSMZRGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Also fixed a few other things:
and had trouble with the current approach. it disabled my screen as soon
as the screen went into hibernate because xrandr stopped detecting the
display.
guidelines
time. This also solved issues with my daisychained displays.
Fixes #29