Correctly check left / right for modifier only key #1298
Merged
+42
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wengxt
force-pushed
the
modifier-left-right
branch
from
aaa645e to
88c5e92
Compare
If modifier-only key can be considered as two parts, modifier and the trigger key. Trigger key's left and right should be considered when checking isReleaseOfModifier(). Fix #1289
wengxt
force-pushed
the
modifier-left-right
branch
from
88c5e92 to
35d0fc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If modifier-only key can be considered as two parts, modifier and
the trigger key. Trigger key's left and right should be considered when
checking isReleaseOfModifier().
Fix #1289