add new dbus method to get current input method info #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hantengc 老k，帮忙看看这个pr，存在一个dbus方法：CurrentInputMethod只能获取到输入法的uniqueName。 |
|
Can you make it return the exact same thing like FullInputMethodGroupInfo does? |
|
@wengxt 目前只缺少了layout，应该不需要返回layout吧？ |
hantengc
force-pushed
the
hantengc_add_new_dbus_api
branch
from
ea53408 to
ef54471
Compare
hantengc
force-pushed
the
hantengc_add_new_dbus_api
branch
2 times, most recently
from
c7f4ec0 to
d19ae4e
Compare
wengxt
requested changes
Mar 17, 2025
hantengc
force-pushed
the
hantengc_add_new_dbus_api
branch
from
d19ae4e to
6741ad1
Compare
wengxt
requested changes
Mar 17, 2025
src/modules/dbus/dbusmodule.cpp
Outdated
| std::string, std::string, std::string, | ||
| std::string, bool, std::string>> | ||
| currentInputMethodInfo() { | ||
| std::vector<dbus::DBusStruct<std::string, std::string, std::string, |
hantengc
force-pushed
the
hantengc_add_new_dbus_api
branch
2 times, most recently
from
eea4106 to
341059b
Compare
wengxt
requested changes
Mar 17, 2025
src/modules/dbus/dbusmodule.cpp
Outdated
| std::string currentIM = instance_->currentInputMethod(); | ||
| const auto *entry = instance_->inputMethodManager().entry(currentIM); | ||
| if (entry == nullptr) { | ||
| return {"", "", "", "", "", "", "", false, ""}; |
There was a problem hiding this comment.
Simply {} should be enough
Also, previously I'd like it to be "sssssssbsa{sv}", while we have nothing for "a{sv}" (empty), we still want it in case we want to add anything in the future.
hantengc
force-pushed
the
hantengc_add_new_dbus_api
branch
from
ae7c0cd to
dadcacf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.