Conversation
wengxt
force-pushed
the
async
branch
2 times, most recently
from
524b0e9 to
9311232
Compare
On Windows, the pipe API is very different from unix that uv_poll will not work easily without some big change. Instead, we introduce an Async event that can be easily mapped to uv_async, while keep self pipe trick on linux for other event loop implementation. We will try to avoid pipe usage in the actual code for simplicity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, the pipe API is very different from unix that uv_poll will not work easily without some big change. Instead, we introduce an Async event that can be easily mapped to uv_async, while keep self pipe trick on linux for other event loop implementation.
We will try to avoid pipe usage in the actual code for simplicity.