allow enable/disable undo/redo buttons#22
Merged
eagleoflqj merged 3 commits intofcitx-contrib:masterfrom Mar 30, 2025
Merged
Conversation
eagleoflqj
requested changes
Mar 24, 2025
Member
eagleoflqj
left a comment
eagleoflqj
left a comment
There was a problem hiding this comment.
When button is disabled, background color should not change on touch.
WhiredPlanck
force-pushed
the
button-enable
branch
from
8584ef4 to
a3780b0
Compare
Contributor
Author
Changed. It may not be the best practice, feel free to polish. |
WhiredPlanck
force-pushed
the
button-enable
branch
from
a3780b0 to
a517a4e
Compare
eagleoflqj
reviewed
Mar 28, 2025
WhiredPlanck
force-pushed
the
button-enable
branch
from
a517a4e to
1e4b0fc
Compare
WhiredPlanck
force-pushed
the
button-enable
branch
from
1e4b0fc to
d381b53
Compare
eagleoflqj
approved these changes
Mar 30, 2025
Member
eagleoflqj
left a comment
eagleoflqj
left a comment
There was a problem hiding this comment.
I revert default to enabled. I think on Android you don't need to use this feature since you don't manage stacks. Also on Harmony we have to disable them on input context switch anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.