Use setuptools entry points instead of a custom script #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@fboender have you have any chance to take a look at this PR? |
mgedmin
force-pushed
the
use-entry-points
branch
from
edd8ffc to
058a212
Compare
mgedmin
added a commit
to mgedmin/scripts
that referenced
this pull request
Jun 8, 2021
The mg branch is upstream + fboender/ansible-cmdb#191 + fboender/ansible-cmdb#214
Should fix fboender#190 and related issues (e.g. the script will not work correctly ansible-cmdb if it's been installed into a non-activated virtualenv).
mgedmin
force-pushed
the
use-entry-points
branch
from
058a212 to
cdeb91e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #190 and related issues (e.g. the previous shell wrapper script would not have worked correctly if ansible-cmdb was installed into a non-activated virtualenv).