Repository navigation
Conversation
The picture stays hidden until it has loaded, but MorphImage only loads once it has been visible, so it never showed and the initial stayed in its place. Load it eagerly, as the sidebar avatar does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The account page showed the initial instead of the profile picture, while the sidebar showed the picture.
The MorphImage stays hidden until its image is ready, but MorphImage only starts loading once it has been visible (or is
eager), so it never loaded. Settingeager: trueloads it right away, the way the sidebar avatar and the now playing cover do.Checked offscreen on a real account: the picture shows in the cookie shape.
Update: also shows your profile picture next to the owner name on your own playlists.