Repository navigation
Conversation
Musixmatch now hands the built-in anonymous token.get a token of zeros, so the app never asks it for lyrics and NetEase is the only source of word timings. A token pasted in Settings > Reading is used for both the full source chain and the word upgrade over Spotify lines, and a change applies to the next track without a restart.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Musixmatch now returns a token of zeros to the anonymous
token.getcall, somxm_tokencaches "blocked" and Musixmatch is never asked for lyrics. NetEase is left as the only source of word timings.This adds a "Musixmatch token" field to Settings > Reading (masked, with the show button the text field already has). The token is read on every lookup, so it is used by both the full source chain and the word upgrade over Spotify lines, and a change applies to the next track without a restart. Empty keeps the current anonymous behaviour.
Translations added for ru and pt.
Tests:
cargo test -p mf-platform -p mf-lyrics -p sf-services, qmllint on SettingsPage.qml, and an offscreen screenshot of the row with a token set.