Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #43.
The playlist, show and episode pages already have a share button that copies the link, so only the artist and album pages were missing one. Both now get the same share button: the artist page next to Follow (
Catalog.artistUrl), the album page next to Save (Catalog.uriUrl). The album header wraps both buttons in a Row, so the Save button is re-indented in the diff.Same icon and strings as the existing buttons ("Copy link", "Link copied"), no new translations. I left out radio, Liked Songs and a Now Playing share button, since the issue marks them as optional.
Release build and RouterHarness pass; both pages compile and instantiate offscreen. qmllint only reports existing warnings on lines I did not touch.