Replace pylint, flake8 and black for ruff (#452)
#453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `flake8`, `pylint` and `black` as requirements to check style and format the code in `env/requirements-style.txt` and `environment.yml`. Update targets in `Makefile` to use ruff to check for style and format the code. Add ruff configs to `pyproject.toml`. Remove the `.pylintrc` file.
Run `make format` to autoformat Pooch codebase with Ruff.
|
TODO: Remove the pylint comments to disable rules per file/line. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the current linters and auto-formatters we are using in Pooch for
ruff.Note
This branch is intended to collect all changes to complete the replacement of the linters. We should not push to this branch, but open PRs against it instead.
I'm planning to merge this branch as soon as we get ruff happy with Pooch. We can leave a few warnings hanging and ignore them temporarily, so we can tackle them later.
When ready, this branch should be MERGED to
mainand not Squash and Merged, so we don't create a huge commit.Important
Make sure that the format passes on CI on PRs targeted to this branch. It's expected that the style check will fail until we solve all warnings, but format should pass.