Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement file upload for package parameter in put_package #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jannic
Copy link

@jannic jannic commented Jul 16, 2023

I noticed that put_package is still not usable because the upload of the package contents isn't implemented.

Of course this merge request is of limited usefulness because the fastly-api source code is generated. But perhaps it's still helpful when you improve the code generator?
For that reason I also didn't bother to replace the unwrap call with proper error handling.

@Integralist
Copy link
Collaborator

👋🏻 Thanks @jannic

I appreciate you providing this working example. I'll take a look at the code-generator template and see if we can work this into there without too much disruption 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants