test: ensure rust and cpp compression matches #32
Conversation
Weixing-Zhang
force-pushed
the
test/rust-and-cpp-compression-matches
branch
from
8ff21b3 to
dc87145
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
tests/test_data.rs
Outdated
| @@ -0,0 +1,45 @@ | |||
| #![cfg(all(feature = "rust", feature = "cpp"))] | |||
There was a problem hiding this comment.
i think its better to move this to tests/common.rs
tests/cpp_compat_tests.rs
Outdated
| ); | ||
| assert_eq!(decoded_cpp, decoded_by_rust); | ||
|
|
||
| for input in get_test_cases(512 + rust::BLOCK_SIZE_128 as usize) { |
There was a problem hiding this comment.
while totally not critical, and probably good for another PR, but it seems it might benefit us in the future to come up with some trait-based API that is the same for both rust and cpp implementation... ideas are welcome
There was a problem hiding this comment.
Completely agreed. For now, I need to apply a small workaround due to the interface between the rust-native implementation and the rust wrapper. A key issue is that the current rust-native code does not support arbitrary input lengths. The cpp implementation appears to tolerate such cases. I have added this to my to-do list once I better understand the algorithm.
2 participants
Implemented: