Code for issues 56 and 57, including tests #58
Conversation
|
@fasseg Any chance a replaceable Tokenizer may be accepted, without the support for handling unknown variables? |
| private Collection<String> undefinedVariables = null; | ||
|
|
||
| public void allowUndefinedVariables(boolean allow) { | ||
| this.undefinedVariables = (allow ? new ArrayList<String>() : null); |
There was a problem hiding this comment.
I think you could use HashSet, or rather LinkedHashSet if you want to preserve tokens order. ArrayList will consume less memory but HashSet will perform better. I'm not sure what is more important here.
The ArrayList:
- contains - O(N)
- add - O(1)
The HashSet or LinkedHashSet:
- contains - O(1)
- add - O(1)
But also, with HashSet you could not check contains(name) since Set guarantees Strings uniqueness on add(name) so the number of operations is smaller.
There was a problem hiding this comment.
ArrayList's add can be O(N), if it needs to reallocate the underlying array. Anyway, it's reasonable to expect the set of unknown variables to be small, so I don't think it really matters.
|
Hi @hallvard, I was just stepping by and left few minor comments in the code :) |
I've implemented support for replaceable Tokenizer and handling unknown variables, as suggested by issues 56 and 57.