Parse sinfo output to manage resources #370
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonio-rodriguez-tam
commented
Mar 19, 2025
antonio-rodriguez-tam
commented
- Add environment parameter to switch from sinfo output to fixed text file
- Add slurm_get_nodes_info function to utils to parse sinfo putput
- Create/Update resources
- Create/Update resources attributes
claire-peters
requested changes
Mar 21, 2025
coldfront/plugins/slurm/management/commands/slurm_manage_resources.py
Outdated
Show resolved
Hide resolved
…revent bulk update error
…revent bulk update error. Fix merge error
…fasrc-coldfront into sinfo_resource_management
claire-peters
requested changes
Mar 26, 2025
There was a problem hiding this comment.
There's also this issue regarding the last_updated timestamp not getting updated when this is run: https://fasrc.slack.com/archives/C07K0P7SLH3/p1743020779949709
| bulk_update_resource = [] | ||
| processed_resource_attribute = [] | ||
| for row in output: | ||
| new_resource, compute_node_created_created = Resource.objects.get_or_create(name=row['nodelist'], defaults={'is_allocatable':False, 'resource_type':compute_node}) |
There was a problem hiding this comment.
Could we also add parent_resource=(Cluster Resource where the node is installed) to the defaults here?
We tracked this to the use of modified = AutoLastModifiedField(_('modified')) preventing modified field to be updated anywhere but on save(). Since we use bulk_update_with_history the models save() is bypassed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.