spv-in: no case fallthrough when last statement allows it

faro-oss · Sep 20, 2021 · dc8a41d · dc8a41d
1 parent 60d0bf8
commit dc8a41d
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/src/front/spv/function.rs b/src/front/spv/function.rs
@@ -576,11 +576,19 @@ impl<'function> BlockContext<'function> {
                                     .map(|&(value, body_idx)| {
                                         let body = lower_impl(blocks, bodies, body_idx);
 
+                                        // Handle simple cases that would make a fallthrough statement unreachable code
+                                        let fall_through = match body.last() {
+                                            Some(&crate::Statement::Break)
+                                            | Some(&crate::Statement::Continue)
+                                            | Some(&crate::Statement::Kill)
+                                            | Some(&crate::Statement::Return { .. }) => false,
+                                            _ => true,
+                                        };
+
                                         crate::SwitchCase {
                                             value,
                                             body,
-                                            // TODO
-                                            fall_through: true,
+                                            fall_through,
                                         }
                                     })
                                     .collect(),