Skip to content

dep: remove pin on jwcrypto#87

Merged
jason-famedly merged 2 commits into
mainfrom
jason/bump-jwcrypto
Apr 29, 2026
Merged

dep: remove pin on jwcrypto#87
jason-famedly merged 2 commits into
mainfrom
jason/bump-jwcrypto

Conversation

@jason-famedly
Copy link
Copy Markdown
Member

@jason-famedly jason-famedly commented Apr 28, 2026

SYN-44

In #84, the jwcrypto module got bounded to 1.5.6 which is lower than the most current version(1.5.7). This was due to work in that jwcrypto version that hardened the length of the token to a specific value. This interfered with the testing of the Synapse token authenticator, as it creates test token with junk data that do not meet this criteria. This was manifesting as a series of errors that reported:

jwcrypto.common.InvalidJWEKeyLength: Expected key of length 512, got 48

It is currently unknown if this will affect production or only the testing environment. This needs to be checked for/asked about with the relevant parties.

The algorithm tested against is HS512 so I assume that is where the 512 bit requirement comes from. 512 bits * 8bit_per_byte = 64 bytes. That sounds manageable.

@jason-famedly jason-famedly requested a review from a team as a code owner April 28, 2026 18:13
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.28%. Comparing base (fded967) to head (6230a76).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #87   +/-   ##
=======================================
  Coverage   73.28%   73.28%           
=======================================
  Files           5        5           
  Lines         756      756           
  Branches      145      145           
=======================================
  Hits          554      554           
  Misses        143      143           
  Partials       59       59           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fded967...6230a76. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@FrenchGithubUser FrenchGithubUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jason-famedly jason-famedly added this pull request to the merge queue Apr 29, 2026
@jason-famedly jason-famedly changed the title Jason/bump jwcrypto dep: remove pin on jwcrypto Apr 29, 2026
Merged via the queue into main with commit 84a327e Apr 29, 2026
5 checks passed
@jason-famedly jason-famedly deleted the jason/bump-jwcrypto branch April 29, 2026 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants