feat: update ssss to centeralise key logic#2317
Conversation
|
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2317 +/- ##
==========================================
- Coverage 55.76% 55.25% -0.51%
==========================================
Files 160 160
Lines 19850 19957 +107
==========================================
- Hits 11069 11028 -41
- Misses 8781 8929 +148
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
c99cee4 to
c115c5e
Compare
c115c5e to
0bbd466
Compare
634e640 to
b349abb
Compare
90c8a0b to
b3bce14
Compare
2067382 to
e836f9f
Compare
| ); | ||
| encryptedContent.removeWhere((k, v) => otherKeys.contains(k)); | ||
| // yes, we are paranoid... | ||
| content['encrypted'] = encryptedContent; |
There was a problem hiding this comment.
eh why are we doing this? (also the previous comment was helpful so someone does not remove the getStored check)
There was a problem hiding this comment.
We need either “assign the mutated copy back into content” or “mutate the nested map in place,” because tryGetMap copies, stripping only the copy would upload unstripped account data. I've added the comment back though.
td-famedly
left a comment
There was a problem hiding this comment.
another review, looks like some of the methods are not really needed
e836f9f to
b659903
Compare
115c05b to
1931270
Compare
1931270 to
f89b314
Compare
Added reusable public migration APIs in SDK SSSS:
Also added private SDK helper:
These now contain the logic to centralised (secret discovery, key iteration, migration, cache warm-up via maybeCacheAll()).