fix(webrtc): resolve remote stream attachment issue and concurrent modification error#2312
Open
2001arman wants to merge 2 commits into
Open
fix(webrtc): resolve remote stream attachment issue and concurrent modification error#23122001arman wants to merge 2 commits into
2001arman wants to merge 2 commits into
Conversation
Contributor
Author
|
Hi @krille-chan, could you please review my PR? This PR fixes a WebRTC video call bug where the remote stream attachment was null due to an incorrect sdpStreamMetadataKey value. It also includes a minor fix for a concurrent modification issue when processing ICE candidates. Please let me know if there’s anything I might have missed. Thanks! |
3cbd2f2 to
f22bffe
Compare
Contributor
|
@td-famedly you are probably best to review this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issues in the WebRTC video call flow where the remote stream was not properly attached, resulting in missing video/audio on the receiver side.
Issues
nulldue to incorrect SDP metadata keyChanges
sdpStreamMetadataKeyfrom:org.matrix.msc3077.sdp_stream_metadata→ to:
sdp_stream_metadata_remoteCandidatesImpact
Concurrent modification during iterationNotes
Testing