Fix flaky tests in CI + failing tests + issue on CI passing with failed tests#2311
Open
coder-with-a-bushido wants to merge 3 commits into
Open
Fix flaky tests in CI + failing tests + issue on CI passing with failed tests#2311coder-with-a-bushido wants to merge 3 commits into
coder-with-a-bushido wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2311 +/- ##
==========================================
+ Coverage 57.19% 58.00% +0.81%
==========================================
Files 160 160
Lines 19795 19795
==========================================
+ Hits 11321 11482 +161
+ Misses 8474 8313 -161
... and 10 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
td-famedly
reviewed
Apr 2, 2026
td-famedly
approved these changes
Apr 2, 2026
coder-with-a-bushido
force-pushed
the
karthi/flaky-test-attempt-2
branch
from
5329175 to
0426051
Compare
coder-with-a-bushido
changed the title
coder-with-a-bushido
force-pushed
the
karthi/flaky-test-attempt-2
branch
from
92192c3 to
ffebaf9
Compare
coder-with-a-bushido
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another attempt since it cannot be reproduced locally
Also fixes CI green even when tests fail like in https://github.com/famedly/matrix-dart-sdk/actions/runs/23843600999/job/69505225066?pr=2307