feat: add sticky events to SyncUpdate#2238
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2238 +/- ##
=======================================
Coverage 57.80% 57.80%
=======================================
Files 158 159 +1
Lines 19679 19756 +77
=======================================
+ Hits 11375 11420 +45
- Misses 8304 8336 +32
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| } | ||
| } | ||
|
|
||
| class StickyEventsUpdate { |
There was a problem hiding this comment.
can you please put the model in the msc_extensions folder? I think it's a bit cleaner this way, as this is still a msc. Having sticky as a paramter in /sync is fine then
There was a problem hiding this comment.
Done thank you 🙏 - although I think I raised this PR prematurely anyway as I don't think the latest matrix server version I'm working with supports sticky events yet. I can mark this PR as draft or close it and then re-open later when the functionality of the msc is usable?
Edit: Release 1.150 included "Expose matrix-org/matrix-spec-proposals#4354 over the legacy (v3) /sync API. (element-hq/synapse#19487)" so this can now be used.
fcc4e5a to
6d4f0b4
Compare
|
Hi @td-famedly please can you re-review this? Release 1.150 included "Expose matrix-org/matrix-spec-proposals#4354 over the legacy (v3) /sync API. (element-hq/synapse#19487)" so the changes here can now be taken advantage of |
refactor: move sticky events to msc_extension directory
a976cf5 to
6a4de41
Compare
Add support for Sticky Events to the
SyncUpdateclass used to model the response of the/syncendpoint.Specifically this is so that its possible to follow the MSC4143: MatrixRTC specification on how to initiate and manage MatrixRTC sessions using the "slot" state event and new concept "sticky" events. The slot state event is not part of this PR to keep it super small and focussed, though that change is also small and can be followed up in another PR (just adding a new
EventTypefor it following themsc_extensiondirectory pattern).I've not attempted to do an
msc_extensionapproach for sticky events as they are retrieved through the/syncendpoint and it doesn't seem feasible to implement it any other way. These events are nullable and so there is no risk of regression and the MatrixRTC proposal itself is quite stable (though not officially merged yet).