New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

android - add support for AGP 8 #120

Open

Timi-Duban wants to merge 1 commit into faizalshap:master from Timi-Duban:feature/add-agp8-support

Timi-Duban commented Aug 7, 2024

Change to support AGP 8 as mentioned here: react-native-community/discussions-and-proposals#671

This does not remove package attribute from AndroidManifest to not lose compatibility with AGP < 8 (React Native < 0.71 versions).

I don't think it's worth maintaining logic to remove that attribute contitionally since it will only cause a warning to users on AGP 8 and above.

MR adapted from @AndreiCalazans work found in another project


          add support for AGP 8

aa79c0d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet