Skip to content

Patch update browsers bin #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 3, 2025
+1 −1
Merged

Patch update browsers bin #44

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0cdc2be
[CLEANUP] Remove VERSION_CHECK_FOO on bin/update-browsers.sh
Jun 8, 2025
738d4fe
[DOCS] Added instruction in bin/update-browsers.sh
Jun 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/update-browsers.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@
# Update the browser regex in the version check script.
#
# Uses a browserslist query to generate this data.
# Needs you to run `npx browserslist-useragent-regexp "defaults, unreleased versions"` before first use
Copy link
Member

@rmccue rmccue Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, why is this required, because npx prompts for install?

Copy link
Contributor Author

@ramonfincken ramonfincken Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes correct. I needed to enter "y"

Copy link
Contributor Author

@ramonfincken ramonfincken Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so I have npm/npx installed. But the command needed a one time only "y" manual enter to work

Copy link
Member

@rmccue rmccue Jun 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it; instead of this comment, let's add --yes to the npx command which should ensure it runs automatically instead :)

set -eo pipefail

BROWSER_QUERY="defaults, unreleased versions"

SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )
VERSION_CHECK_FOO="$SCRIPT_DIR/../inc/version-check/foo.txt"
VERSION_CHECK_FILE="$SCRIPT_DIR/../inc/version-check/namespace.php"

LINE_START="const BROWSER_REGEX = ";
Expand Down